target: change sprintf to snprintf in transport_dump_vpd_ident
"buf" is 128 characters and "vpd->device_identifier" is 256. It makes the static checkers complain. Also bump VPD_TMP_BUF_SIZE to match INQUIRY_VPD_DEVICE_IDENTIFIER_LEN. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
parent
8f67835f1e
commit
703d641d87
|
@ -907,15 +907,18 @@ int transport_dump_vpd_ident(
|
|||
|
||||
switch (vpd->device_identifier_code_set) {
|
||||
case 0x01: /* Binary */
|
||||
sprintf(buf, "T10 VPD Binary Device Identifier: %s\n",
|
||||
snprintf(buf, sizeof(buf),
|
||||
"T10 VPD Binary Device Identifier: %s\n",
|
||||
&vpd->device_identifier[0]);
|
||||
break;
|
||||
case 0x02: /* ASCII */
|
||||
sprintf(buf, "T10 VPD ASCII Device Identifier: %s\n",
|
||||
snprintf(buf, sizeof(buf),
|
||||
"T10 VPD ASCII Device Identifier: %s\n",
|
||||
&vpd->device_identifier[0]);
|
||||
break;
|
||||
case 0x03: /* UTF-8 */
|
||||
sprintf(buf, "T10 VPD UTF-8 Device Identifier: %s\n",
|
||||
snprintf(buf, sizeof(buf),
|
||||
"T10 VPD UTF-8 Device Identifier: %s\n",
|
||||
&vpd->device_identifier[0]);
|
||||
break;
|
||||
default:
|
||||
|
|
|
@ -44,7 +44,7 @@
|
|||
/* Used by core_alua_store_tg_pt_gp_info() and target_core_alua_tg_pt_gp_show_attr_members() */
|
||||
#define TG_PT_GROUP_NAME_BUF 256
|
||||
/* Used to parse VPD into struct t10_vpd */
|
||||
#define VPD_TMP_BUF_SIZE 128
|
||||
#define VPD_TMP_BUF_SIZE 254
|
||||
/* Used by transport_generic_cmd_sequencer() */
|
||||
#define READ_BLOCK_LEN 6
|
||||
#define READ_CAP_LEN 8
|
||||
|
|
Loading…
Reference in a new issue