redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

[media] stk-webcam: Delete an unnecessary check before the function call "vfree"

Browse source 
The vfree() function performs also input parameter validation.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Markus Elfring 2015-02-03 14:36:35 -03:00 committed by Mauro Carvalho Chehab
parent d585c1e14a
commit 704b3f4c11
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/media/usb/stkwebcam/stk-webcam.c
View file

@ -556,10 +556,8 @@ static int stk_free_sio_buffers(struct stk_camera *dev)
nbufs = dev->n_sbufs;
dev->n_sbufs = 0;
spin_unlock_irqrestore(&dev->spinlock, flags);
for (i = 0; i < nbufs; i++) {
if (dev->sio_bufs[i].buffer != NULL)
vfree(dev->sio_bufs[i].buffer);
}
for (i = 0; i < nbufs; i++)
vfree(dev->sio_bufs[i].buffer);
kfree(dev->sio_bufs);
dev->sio_bufs = NULL;
return 0;