redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

Ignore bogus ACPI info for offline CPUs

Browse source 
Booting a SMP kernel with maxcpus=1 on a SMP system leads to a hard hang,
because ACPI ignores the maxcpus setting and sends timer broadcast info for
the offline CPUs.  This results in a stuck for ever call to
smp_call_function_single() on an offline CPU.

Ignore the bogus information and print a kernel error to remind ACPI
folks to fix it.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Thomas Gleixner 2007-05-23 13:57:30 -07:00 committed by Linus Torvalds
parent 88f18ba028
commit 72fcde9662
1 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
kernel/time/tick-broadcast.c
View file

@ -243,11 +243,18 @@ void tick_broadcast_on_off(unsigned long reason, int *oncpu)
{
int cpu = get_cpu();
if (cpu == *oncpu)
tick_do_broadcast_on_off(&reason);
else
smp_call_function_single(*oncpu, tick_do_broadcast_on_off,
&reason, 1, 1);
if (!cpu_isset(*oncpu, cpu_online_map)) {
printk(KERN_ERR "tick-braodcast: ignoring broadcast for "
"offline CPU #%d\n", *oncpu);
} else {
if (cpu == *oncpu)
tick_do_broadcast_on_off(&reason);
else
smp_call_function_single(*oncpu,
tick_do_broadcast_on_off,
&reason, 1, 1);
}
put_cpu();
}