redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

powerpc/pci: Fix checking for child bridges in PCI code. 

pci_device_to_OF_node() can return null, and list_for_each_entry will
never enter the loop when dev is NULL, so it looks like this test is
a typo.

Reported-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
wifi-calibration
Grant Likely 2010-08-18 08:27:55 +00:00 committed by Benjamin Herrenschmidt
parent c686ecf504
commit 76ec01dbb7
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
arch/powerpc/kernel/pci_of_scan.c
View File

@ -336,7 +336,8 @@ static void __devinit __of_scan_bus(struct device_node *node,
if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE ||
dev->hdr_type == PCI_HEADER_TYPE_CARDBUS) {
struct device_node *child = pci_device_to_OF_node(dev);
of_scan_pci_bridge(child, dev);
if (child)
of_scan_pci_bridge(child, dev);
}
}
}