staging: most: Eliminate usage of symbolic permissions
Fix checkpatch warnings regarding the use of symbolic permissions. Where the MOST_CHANNEL_ATTR macro is used, convert to octal permissions over symbolic. Where _ATTR is used directly, replace with _ATTR_RW/_ATTR_WO and update the show/store function names appropriately. Signed-off-by: Jason Litzinger <jlitzingerdev@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
3ce173a162
commit
7e47629e7a
|
@ -342,7 +342,7 @@ static ssize_t show_channel_starving(struct most_c_obj *c,
|
||||||
}
|
}
|
||||||
|
|
||||||
#define create_show_channel_attribute(val) \
|
#define create_show_channel_attribute(val) \
|
||||||
static MOST_CHNL_ATTR(val, S_IRUGO, show_##val, NULL)
|
static MOST_CHNL_ATTR(val, 0444, show_##val, NULL)
|
||||||
|
|
||||||
create_show_channel_attribute(available_directions);
|
create_show_channel_attribute(available_directions);
|
||||||
create_show_channel_attribute(available_datatypes);
|
create_show_channel_attribute(available_datatypes);
|
||||||
|
@ -494,9 +494,7 @@ static ssize_t store_set_packets_per_xact(struct most_c_obj *c,
|
||||||
}
|
}
|
||||||
|
|
||||||
#define create_channel_attribute(value) \
|
#define create_channel_attribute(value) \
|
||||||
static MOST_CHNL_ATTR(value, S_IRUGO | S_IWUSR, \
|
static MOST_CHNL_ATTR(value, 0644, show_##value, store_##value)
|
||||||
show_##value, \
|
|
||||||
store_##value)
|
|
||||||
|
|
||||||
create_channel_attribute(set_buffer_size);
|
create_channel_attribute(set_buffer_size);
|
||||||
create_channel_attribute(set_number_of_buffers);
|
create_channel_attribute(set_number_of_buffers);
|
||||||
|
@ -690,7 +688,7 @@ static ssize_t show_interface(struct most_inst_obj *instance_obj,
|
||||||
}
|
}
|
||||||
|
|
||||||
#define create_inst_attribute(value) \
|
#define create_inst_attribute(value) \
|
||||||
static MOST_INST_ATTR(value, S_IRUGO, show_##value, NULL)
|
static MOST_INST_ATTR(value, 0444, show_##value, NULL)
|
||||||
|
|
||||||
create_inst_attribute(description);
|
create_inst_attribute(description);
|
||||||
create_inst_attribute(interface);
|
create_inst_attribute(interface);
|
||||||
|
@ -849,7 +847,7 @@ static void most_aim_release(struct kobject *kobj)
|
||||||
kfree(aim_obj);
|
kfree(aim_obj);
|
||||||
}
|
}
|
||||||
|
|
||||||
static ssize_t show_add_link(struct most_aim_obj *aim_obj,
|
static ssize_t add_link_show(struct most_aim_obj *aim_obj,
|
||||||
struct most_aim_attribute *attr,
|
struct most_aim_attribute *attr,
|
||||||
char *buf)
|
char *buf)
|
||||||
{
|
{
|
||||||
|
@ -966,7 +964,7 @@ most_c_obj *get_channel_by_name(char *mdev, char *mdev_ch)
|
||||||
* (1) would create the device node /dev/my_rxchannel
|
* (1) would create the device node /dev/my_rxchannel
|
||||||
* (2) would create the device node /dev/mdev1-ep81
|
* (2) would create the device node /dev/mdev1-ep81
|
||||||
*/
|
*/
|
||||||
static ssize_t store_add_link(struct most_aim_obj *aim_obj,
|
static ssize_t add_link_store(struct most_aim_obj *aim_obj,
|
||||||
struct most_aim_attribute *attr,
|
struct most_aim_attribute *attr,
|
||||||
const char *buf,
|
const char *buf,
|
||||||
size_t len)
|
size_t len)
|
||||||
|
@ -1016,7 +1014,7 @@ static ssize_t store_add_link(struct most_aim_obj *aim_obj,
|
||||||
}
|
}
|
||||||
|
|
||||||
static struct most_aim_attribute most_aim_attr_add_link =
|
static struct most_aim_attribute most_aim_attr_add_link =
|
||||||
__ATTR(add_link, S_IRUGO | S_IWUSR, show_add_link, store_add_link);
|
__ATTR_RW(add_link);
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* store_remove_link - store function for remove_link attribute
|
* store_remove_link - store function for remove_link attribute
|
||||||
|
@ -1028,7 +1026,7 @@ static struct most_aim_attribute most_aim_attr_add_link =
|
||||||
* Example:
|
* Example:
|
||||||
* echo "mdev0:ep81" >remove_link
|
* echo "mdev0:ep81" >remove_link
|
||||||
*/
|
*/
|
||||||
static ssize_t store_remove_link(struct most_aim_obj *aim_obj,
|
static ssize_t remove_link_store(struct most_aim_obj *aim_obj,
|
||||||
struct most_aim_attribute *attr,
|
struct most_aim_attribute *attr,
|
||||||
const char *buf,
|
const char *buf,
|
||||||
size_t len)
|
size_t len)
|
||||||
|
@ -1059,7 +1057,7 @@ static ssize_t store_remove_link(struct most_aim_obj *aim_obj,
|
||||||
}
|
}
|
||||||
|
|
||||||
static struct most_aim_attribute most_aim_attr_remove_link =
|
static struct most_aim_attribute most_aim_attr_remove_link =
|
||||||
__ATTR(remove_link, S_IWUSR, NULL, store_remove_link);
|
__ATTR_WO(remove_link);
|
||||||
|
|
||||||
static struct attribute *most_aim_def_attrs[] = {
|
static struct attribute *most_aim_def_attrs[] = {
|
||||||
&most_aim_attr_add_link.attr,
|
&most_aim_attr_add_link.attr,
|
||||||
|
|
Loading…
Reference in a new issue