redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

tracing: Change syscall_*regfunc() to check PF_KTHREAD and use for_each_process_thread()

Browse source 
1. Remove _irqsafe from syscall_regfunc/syscall_unregfunc,
   read_lock(tasklist) doesn't need to disable irqs.

2. Change this code to avoid the deprecated do_each_thread()
   and use for_each_process_thread() (stolen from the patch
   from Frederic).

3. Change syscall_regfunc() to check PF_KTHREAD to skip
   the kernel threads, ->mm != NULL is the common mistake.

   Note: probably this check should be simply removed, needs
   another patch.

[fweisbec@gmail.com: s/do_each_thread/for_each_process_thread/]
Link: http://lkml.kernel.org/p/20140413185918.GC20668@redhat.com

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
This commit is contained in:
Oleg Nesterov 2014-04-13 20:59:18 +02:00 committed by Steven Rostedt
parent 4af4206be2
commit 8063e41d2f
1 changed files with 11 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
kernel/tracepoint.c
View file

@ -492,33 +492,31 @@ static int sys_tracepoint_refcount;
void syscall_regfunc(void) void syscall_regfunc(void)
{ {
unsigned long flags; struct task_struct *p, *t;
struct task_struct *g, *t;
if (!sys_tracepoint_refcount) { if (!sys_tracepoint_refcount) {
read_lock_irqsave(&tasklist_lock, flags); read_lock(&tasklist_lock);
do_each_thread(g, t) { for_each_process_thread(p, t) {
/* Skip kernel threads. */ /* Skip kernel threads. */
if (t->mm) if (!(t->flags & PF_KTHREAD))
set_tsk_thread_flag(t, TIF_SYSCALL_TRACEPOINT); set_tsk_thread_flag(t, TIF_SYSCALL_TRACEPOINT);
} while_each_thread(g, t); }
read_unlock_irqrestore(&tasklist_lock, flags); read_unlock(&tasklist_lock);
} }
sys_tracepoint_refcount++; sys_tracepoint_refcount++;
} }
void syscall_unregfunc(void) void syscall_unregfunc(void)
{ {
unsigned long flags; struct task_struct *p, *t;
struct task_struct *g, *t;
sys_tracepoint_refcount--; sys_tracepoint_refcount--;
if (!sys_tracepoint_refcount) { if (!sys_tracepoint_refcount) {
read_lock_irqsave(&tasklist_lock, flags); read_lock(&tasklist_lock);
do_each_thread(g, t) { for_each_process_thread(p, t) {
clear_tsk_thread_flag(t, TIF_SYSCALL_TRACEPOINT); clear_tsk_thread_flag(t, TIF_SYSCALL_TRACEPOINT);
} while_each_thread(g, t); }
read_unlock_irqrestore(&tasklist_lock, flags); read_unlock(&tasklist_lock);
} }
} }
#endif #endif