redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

gpio: viperboard: Be sure to clamp return value

Browse source 
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Lars Poeschel <poeschel@lemonage.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Linus Walleij 2015-12-21 14:58:52 +01:00
parent c9d4ab030c
commit 80776df4f5
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/gpio/gpio-viperboard.c
View file

@ -95,7 +95,7 @@ static int vprbrd_gpioa_get(struct gpio_chip *chip,
/* if io is set to output, just return the saved value */
if (gpio->gpioa_out & (1 << offset))
return gpio->gpioa_val & (1 << offset);
return !!(gpio->gpioa_val & (1 << offset));
mutex_lock(&vb->lock);