redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

ARM: dts: sunxi: Explicitly enable pull-ups for MMC pins 

In the past, all the MMC pins had

	allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;

which was actually a no-op. We were relying on U-boot to set the bias
pull up for us. These properties were removed as part of the fix up to
actually support no bias on the pins. During the transition some boards
experienced regular MMC time-outs during normal operation, while others
completely failed to initialize the SD card.

Given that MMC starts in open-drain mode and the pull-ups are required,
it's best to enable it for all the pin settings.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
zero-colors
Chen-Yu Tsai 2016-11-17 17:34:38 +08:00 committed by Maxime Ripard
parent 1edcd36fcb
commit 80ee72e7e9
8 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
arch/arm/boot/dts/sun4i-a10.dtsi
View File

@ -1023,6 +1023,7 @@
"PF3", "PF4", "PF5";
function = "mmc0";
drive-strength = <30>;
bias-pull-up;
};
mmc0_cd_pin_reference_design: mmc0_cd_pin@0 {

1
arch/arm/boot/dts/sun5i.dtsi
View File

@ -582,6 +582,7 @@
"PF4", "PF5";
function = "mmc0";
drive-strength = <30>;
bias-pull-up;
};
mmc2_pins_a: mmc2@0 {

4
arch/arm/boot/dts/sun6i-a31.dtsi
View File

@ -547,6 +547,7 @@
"PF3", "PF4", "PF5";
function = "mmc0";
drive-strength = <30>;
bias-pull-up;
};
mmc1_pins_a: mmc1@0 {
@ -554,6 +555,7 @@
"PG4", "PG5";
function = "mmc1";
drive-strength = <30>;
bias-pull-up;
};
mmc2_pins_a: mmc2@0 {
@ -571,6 +573,7 @@
"PC24";
function = "mmc2";
drive-strength = <30>;
bias-pull-up;
};
mmc3_8bit_emmc_pins: mmc3@1 {
@ -580,6 +583,7 @@
"PC24";
function = "mmc3";
drive-strength = <40>;
bias-pull-up;
};
uart0_pins_a: uart0@0 {

2
arch/arm/boot/dts/sun7i-a20.dtsi
View File

@ -1179,6 +1179,7 @@
"PF3", "PF4", "PF5";
function = "mmc0";
drive-strength = <30>;
bias-pull-up;
};
mmc0_cd_pin_reference_design: mmc0_cd_pin@0 {
@ -1200,6 +1201,7 @@
"PI7", "PI8", "PI9";
function = "mmc3";
drive-strength = <30>;
bias-pull-up;
};
ps20_pins_a: ps20@0 {

3
arch/arm/boot/dts/sun8i-a23-a33.dtsi
View File

@ -293,6 +293,7 @@
"PF3", "PF4", "PF5";
function = "mmc0";
drive-strength = <30>;
bias-pull-up;
};
mmc1_pins_a: mmc1@0 {
@ -300,6 +301,7 @@
"PG3", "PG4", "PG5";
function = "mmc1";
drive-strength = <30>;
bias-pull-up;
};
mmc2_8bit_pins: mmc2_8bit {
@ -309,6 +311,7 @@
"PC15", "PC16";
function = "mmc2";
drive-strength = <30>;
bias-pull-up;
};
pwm0_pins: pwm0 {

1
arch/arm/boot/dts/sun8i-a83t.dtsi
View File

@ -171,6 +171,7 @@
"PF3", "PF4", "PF5";
function = "mmc0";
drive-strength = <30>;
bias-pull-up;
};
uart0_pins_a: uart0@0 {

3
arch/arm/boot/dts/sun8i-h3.dtsi
View File

@ -348,6 +348,7 @@
"PF4", "PF5";
function = "mmc0";
drive-strength = <30>;
bias-pull-up;
};
mmc0_cd_pin: mmc0_cd_pin@0 {
@ -361,6 +362,7 @@
"PG4", "PG5";
function = "mmc1";
drive-strength = <30>;
bias-pull-up;
};
mmc2_8bit_pins: mmc2_8bit {
@ -370,6 +372,7 @@
"PC15", "PC16";
function = "mmc2";
drive-strength = <30>;
bias-pull-up;
};
spi0_pins: spi0 {

3
arch/arm/boot/dts/sun9i-a80.dtsi
View File

@ -696,6 +696,7 @@
"PF4", "PF5";
function = "mmc0";
drive-strength = <30>;
bias-pull-up;
};
mmc1_pins: mmc1 {
@ -703,6 +704,7 @@
"PG4", "PG5";
function = "mmc1";
drive-strength = <30>;
bias-pull-up;
};
mmc2_8bit_pins: mmc2_8bit {
@ -712,6 +714,7 @@
"PC16";
function = "mmc2";
drive-strength = <30>;
bias-pull-up;
};
uart0_pins_a: uart0@0 {