HID: ignore all non-LED usages in output fields in hid-input
We have to ignore all non-LED usages in output fields if the report descriptor of the device specifies any. If we don't do so, the devices which contain the same usages both in input and output reports with different parameters will mess things up. In hid-input, we currently care only for the input usages, with exception for LEDs. All other output usages should be properly handled by appropriate force-feedback driver. Fixes auto-calibration for Saitek Cyborg Evo Force joystick. Reported-by: Renato Golin <rengolin@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
parent
77b296629d
commit
82eb121989
|
@ -355,6 +355,13 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
|
||||||
if (field->flags & HID_MAIN_ITEM_CONSTANT)
|
if (field->flags & HID_MAIN_ITEM_CONSTANT)
|
||||||
goto ignore;
|
goto ignore;
|
||||||
|
|
||||||
|
/* only LED usages are supported in output fields */
|
||||||
|
if (field->report_type == HID_OUTPUT_REPORT &&
|
||||||
|
(usage->hid & HID_USAGE_PAGE) != HID_UP_LED) {
|
||||||
|
dbg_hid_line(" [non-LED output field] ");
|
||||||
|
goto ignore;
|
||||||
|
}
|
||||||
|
|
||||||
switch (usage->hid & HID_USAGE_PAGE) {
|
switch (usage->hid & HID_USAGE_PAGE) {
|
||||||
|
|
||||||
case HID_UP_UNDEFINED:
|
case HID_UP_UNDEFINED:
|
||||||
|
|
Loading…
Reference in a new issue