redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

[media] max2175: remove an useless comparision

Browse source 
load is an unsigned integer. So, it is always bigger or equal
to zero, as reported by gcc:

	drivers/media/i2c/max2175.c: In function 'max2175_refout_load_to_bits':
	drivers/media/i2c/max2175.c:1272:11: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
	  if (load >= 0 && load <= 40)
	           ^~

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Mauro Carvalho Chehab 2017-06-20 07:11:15 -03:00
parent fbe19d1f06
commit 8ca00927d6
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/media/i2c/max2175.c
View file

@ -1269,7 +1269,7 @@ static const struct v4l2_ctrl_config max2175_na_rx_mode = {
static int max2175_refout_load_to_bits(struct i2c_client *client, u32 load,
u32 *bits)
{
if (load >= 0 && load <= 40)
if (load <= 40)
*bits = load / 10;
else if (load >= 60 && load <= 70)
*bits = load / 10 - 1;