Bluetooth: l2cap and rfcomm: fix 1 byte infoleak to userspace.
Structures "l2cap_conninfo" and "rfcomm_conninfo" have one padding byte each. This byte in "cinfo" is copied to userspace uninitialized. Signed-off-by: Filip Palian <filip.palian@pjwstk.edu.pl> Acked-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
This commit is contained in:
parent
51892dbbd5
commit
8d03e971cf
|
@ -413,6 +413,7 @@ static int l2cap_sock_getsockopt_old(struct socket *sock, int optname, char __us
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
memset(&cinfo, 0, sizeof(cinfo));
|
||||||
cinfo.hci_handle = chan->conn->hcon->handle;
|
cinfo.hci_handle = chan->conn->hcon->handle;
|
||||||
memcpy(cinfo.dev_class, chan->conn->hcon->dev_class, 3);
|
memcpy(cinfo.dev_class, chan->conn->hcon->dev_class, 3);
|
||||||
|
|
||||||
|
|
|
@ -788,6 +788,7 @@ static int rfcomm_sock_getsockopt_old(struct socket *sock, int optname, char __u
|
||||||
|
|
||||||
l2cap_sk = rfcomm_pi(sk)->dlc->session->sock->sk;
|
l2cap_sk = rfcomm_pi(sk)->dlc->session->sock->sk;
|
||||||
|
|
||||||
|
memset(&cinfo, 0, sizeof(cinfo));
|
||||||
cinfo.hci_handle = conn->hcon->handle;
|
cinfo.hci_handle = conn->hcon->handle;
|
||||||
memcpy(cinfo.dev_class, conn->hcon->dev_class, 3);
|
memcpy(cinfo.dev_class, conn->hcon->dev_class, 3);
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue