redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

mtip32xx: don't open-code memdup_user()

Browse source 
[folded a fix by Dan Carpenter]

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro 2016-01-02 14:56:33 -05:00
parent 793b796ebf
commit 8ed6010d50
1 changed files with 8 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
drivers/block/mtip32xx/mtip32xx.c
View file

@ -2029,13 +2029,10 @@ static int exec_drive_taskfile(struct driver_data *dd,
} }
if (taskout) { if (taskout) {
outbuf = kzalloc(taskout, GFP_KERNEL); outbuf = memdup_user(buf + outtotal, taskout);
if (outbuf == NULL) { if (IS_ERR(outbuf)) {
err = -ENOMEM; err = PTR_ERR(outbuf);
goto abort; outbuf = NULL;
}
if (copy_from_user(outbuf, buf + outtotal, taskout)) {
err = -EFAULT;
goto abort; goto abort;
} }
outbuf_dma = pci_map_single(dd->pdev, outbuf_dma = pci_map_single(dd->pdev,
@ -2050,14 +2047,10 @@ static int exec_drive_taskfile(struct driver_data *dd,
} }
if (taskin) { if (taskin) {
inbuf = kzalloc(taskin, GFP_KERNEL); inbuf = memdup_user(buf + intotal, taskin);
if (inbuf == NULL) { if (IS_ERR(inbuf)) {
err = -ENOMEM; err = PTR_ERR(inbuf);
goto abort; inbuf = NULL;
}
if (copy_from_user(inbuf, buf + intotal, taskin)) {
err = -EFAULT;
goto abort; goto abort;
} }
inbuf_dma = pci_map_single(dd->pdev, inbuf_dma = pci_map_single(dd->pdev,