base: core: WARN() about bogus permissions on device attributes
Whenever a struct device_attribute is registered with mismatched permissions - read permission without a show routine or write permission without store routine - we will issue a big warning so we catch those early enough. Signed-off-by: Felipe Balbi <balbi@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
be871b7e54
commit
8f46baaa7e
|
@ -563,8 +563,15 @@ int device_create_file(struct device *dev,
|
|||
const struct device_attribute *attr)
|
||||
{
|
||||
int error = 0;
|
||||
if (dev)
|
||||
|
||||
if (dev) {
|
||||
WARN(((attr->attr.mode & S_IWUGO) && !attr->store),
|
||||
"Write permission without 'store'\n");
|
||||
WARN(((attr->attr.mode & S_IRUGO) && !attr->show),
|
||||
"Read permission without 'show'\n");
|
||||
error = sysfs_create_file(&dev->kobj, &attr->attr);
|
||||
}
|
||||
|
||||
return error;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue