redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

jz4740-battery: Remove unnecessary platform_set_drvdata()

Browse source 
The driver core clears the driver data to NULL after device_release or on
probe failure, since commit 0998d06310
(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is
not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Anton Vorontsov <anton@enomsg.org>
This commit is contained in:
Jingoo Han 2013-05-06 13:22:41 +09:00 committed by Anton Vorontsov
parent 6fe6a40a83
commit 8ff3fb2902
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/power/jz4740-battery.c
View file

@ -292,7 +292,7 @@ static int jz_battery_probe(struct platform_device *pdev)
jz_battery); jz_battery);
if (ret) { if (ret) {
dev_err(&pdev->dev, "Failed to request irq %d\n", ret); dev_err(&pdev->dev, "Failed to request irq %d\n", ret);
goto err; return ret;
} }
disable_irq(jz_battery->irq); disable_irq(jz_battery->irq);
@ -349,8 +349,6 @@ err_free_gpio:
gpio_free(jz_battery->pdata->gpio_charge); gpio_free(jz_battery->pdata->gpio_charge);
err_free_irq: err_free_irq:
free_irq(jz_battery->irq, jz_battery); free_irq(jz_battery->irq, jz_battery);
err:
platform_set_drvdata(pdev, NULL);
return ret; return ret;
} }