From 944d53a2b7616cb51f4f9a2e2bafcab16ea2bc25 Mon Sep 17 00:00:00 2001 From: Anson Huang Date: Sat, 3 Nov 2018 10:44:49 +0800 Subject: [PATCH] MLK-20202 clocksource: imx-gpt: fix coverity issues This patch fixes coverity issues as below: 1. resource leak 2. possible case of division by zero. Fix #1 by kfree the resource before return error; Fix #2 by adding zero check before registering delay timer. Signed-off-by: Anson Huang Reviewed-by: Bai Ping --- drivers/clocksource/timer-imx-gpt.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/clocksource/timer-imx-gpt.c b/drivers/clocksource/timer-imx-gpt.c index 9d7dd093bf64..85ef1674d62f 100644 --- a/drivers/clocksource/timer-imx-gpt.c +++ b/drivers/clocksource/timer-imx-gpt.c @@ -171,6 +171,9 @@ static int __init mxc_clocksource_init(struct imx_timer *imxtm) unsigned int c = clk_get_rate(imxtm->clk_per); void __iomem *reg = imxtm->base + imxtm->gpt->reg_tcn; + if (c == 0) + return -EINVAL; + #ifndef CONFIG_ARM64 imx_delay_timer.read_current_timer = &imx_read_current_timer; imx_delay_timer.freq = c; @@ -493,12 +496,16 @@ static int __init mxc_timer_init_dt(struct device_node *np, enum imx_gpt_type t return -ENOMEM; imxtm->base = of_iomap(np, 0); - if (!imxtm->base) + if (!imxtm->base) { + kfree(imxtm); return -ENXIO; + } imxtm->irq = irq_of_parse_and_map(np, 0); - if (imxtm->irq <= 0) + if (imxtm->irq <= 0) { + kfree(imxtm); return -EINVAL; + } imxtm->clk_ipg = of_clk_get_by_name(np, "ipg");