redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

gpiolib: fix chip order in gpio list

Browse source 
In some situations the gpio_list order is not correct.
As a consequence gpiochip_find_base returns the same
base number twice. This happens when a first ship is added
with manual base number, then other ships are added using
automatic base number.

To prevent this behaviour, this patch add the new chip after
the last element of the gpio list.

Signed-off-by: Julien Grossholtz <julien.grossholtz@savoirfairelinux.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Julien Grossholtz 2016-01-07 16:46:45 -05:00 committed by Linus Walleij
parent 78179989a0
commit 96098df125
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/gpio/gpiolib.c
View file

@ -226,8 +226,10 @@ static int gpiochip_add_to_list(struct gpio_chip *chip)
*/
iterator = list_last_entry(&gpio_chips, struct gpio_chip, list);
if (iterator->base + iterator->ngpio <= chip->base)
goto found;
if (iterator->base + iterator->ngpio <= chip->base) {
list_add(&chip->list, &iterator->list);
return 0;
}
dev_err(chip->parent,
"GPIO integer space overlap, cannot add chip\n");