redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

mfd: twl4030-audio: Remove unnecessary platform_set_drvdata()

Browse source 
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d06310
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
This commit is contained in:
Jingoo Han 2013-05-06 13:06:31 +09:00 committed by Samuel Ortiz
parent 9f74f5b541
commit 96ac2d1a3a
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/mfd/twl4030-audio.c
View file

@ -261,10 +261,8 @@ static int twl4030_audio_probe(struct platform_device *pdev)
ret = -ENODEV; ret = -ENODEV;
} }
if (ret) { if (ret)
platform_set_drvdata(pdev, NULL);
twl4030_audio_dev = NULL; twl4030_audio_dev = NULL;
}
return ret; return ret;
} }
@ -272,7 +270,6 @@ static int twl4030_audio_probe(struct platform_device *pdev)
static int twl4030_audio_remove(struct platform_device *pdev) static int twl4030_audio_remove(struct platform_device *pdev)
{ {
mfd_remove_devices(&pdev->dev); mfd_remove_devices(&pdev->dev);
platform_set_drvdata(pdev, NULL);
twl4030_audio_dev = NULL; twl4030_audio_dev = NULL;
return 0; return 0;