libnvdimm, pfn: make 'resource' attribute only readable by root
commit26417ae4fc
upstream. For the same reason that /proc/iomem returns 0's for non-root readers and acpi tables are root-only, make the 'resource' attribute for pfn devices only readable by root. Otherwise we disclose physical address information. Fixes:f6ed58c70d
("libnvdimm, pfn: 'resource'-address and 'size'...") Reported-by: Dave Hansen <dave.hansen@linux.intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
0f8fb6d5c2
commit
9a31016ea0
|
@ -282,8 +282,16 @@ static struct attribute *nd_pfn_attributes[] = {
|
||||||
NULL,
|
NULL,
|
||||||
};
|
};
|
||||||
|
|
||||||
|
static umode_t pfn_visible(struct kobject *kobj, struct attribute *a, int n)
|
||||||
|
{
|
||||||
|
if (a == &dev_attr_resource.attr)
|
||||||
|
return 0400;
|
||||||
|
return a->mode;
|
||||||
|
}
|
||||||
|
|
||||||
struct attribute_group nd_pfn_attribute_group = {
|
struct attribute_group nd_pfn_attribute_group = {
|
||||||
.attrs = nd_pfn_attributes,
|
.attrs = nd_pfn_attributes,
|
||||||
|
.is_visible = pfn_visible,
|
||||||
};
|
};
|
||||||
|
|
||||||
static const struct attribute_group *nd_pfn_attribute_groups[] = {
|
static const struct attribute_group *nd_pfn_attribute_groups[] = {
|
||||||
|
|
Loading…
Reference in a new issue