stmmac: prevent probe drivers to crash kernel
In the case when alloc_netdev fails we return NULL to a caller. But there is no check for NULL in the probe drivers. This patch changes NULL to an error pointer. The function description is amended to reflect what we may get returned. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
24e579c889
commit
9afec6efc6
|
@ -2778,6 +2778,9 @@ static int stmmac_hw_init(struct stmmac_priv *priv)
|
|||
* @addr: iobase memory address
|
||||
* Description: this is the main probe function used to
|
||||
* call the alloc_etherdev, allocate the priv structure.
|
||||
* Return:
|
||||
* on success the new private structure is returned, otherwise the error
|
||||
* pointer.
|
||||
*/
|
||||
struct stmmac_priv *stmmac_dvr_probe(struct device *device,
|
||||
struct plat_stmmacenet_data *plat_dat,
|
||||
|
@ -2789,7 +2792,7 @@ struct stmmac_priv *stmmac_dvr_probe(struct device *device,
|
|||
|
||||
ndev = alloc_etherdev(sizeof(struct stmmac_priv));
|
||||
if (!ndev)
|
||||
return NULL;
|
||||
return ERR_PTR(-ENOMEM);
|
||||
|
||||
SET_NETDEV_DEV(ndev, device);
|
||||
|
||||
|
|
Loading…
Reference in a new issue