redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

ALSA: usb-audio: void return type of snd_usb_endpoint_deactivate()

Browse source 
The return value of snd_usb_endpoint_deactivate() is not used,
make the function have no return value.
Update the documentation to reflect what the function is actually
doing.

Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Eldad Zack 2013-10-06 22:31:10 +02:00 committed by Takashi Iwai
parent 239b9f7990
commit 9b7c552bba
2 changed files with 6 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
sound/usb/endpoint.c
View file

@ -946,28 +946,23 @@ void snd_usb_endpoint_stop(struct snd_usb_endpoint *ep)
* *
* @ep: the endpoint to deactivate * @ep: the endpoint to deactivate
* *
* If the endpoint is not currently in use, this functions will select the * If the endpoint is not currently in use, this functions will
* alternate interface setting 0 for the interface of this endpoint. * deactivate its associated URBs.
* *
* In case of any active users, this functions does nothing. * In case of any active users, this functions does nothing.
*
* Returns an error if usb_set_interface() failed, 0 in all other
* cases.
*/ */
int snd_usb_endpoint_deactivate(struct snd_usb_endpoint *ep) void snd_usb_endpoint_deactivate(struct snd_usb_endpoint *ep)
{ {
if (!ep) if (!ep)
return -EINVAL; return;
if (ep->use_count != 0) if (ep->use_count != 0)
return 0; return;
deactivate_urbs(ep, true); deactivate_urbs(ep, true);
wait_clear_urbs(ep); wait_clear_urbs(ep);
clear_bit(EP_FLAG_ACTIVATED, &ep->flags); clear_bit(EP_FLAG_ACTIVATED, &ep->flags);
return 0;
} }
/** /**

2
sound/usb/endpoint.h
View file

@ -22,7 +22,7 @@ int snd_usb_endpoint_start(struct snd_usb_endpoint *ep, bool can_sleep);
void snd_usb_endpoint_stop(struct snd_usb_endpoint *ep); void snd_usb_endpoint_stop(struct snd_usb_endpoint *ep);
void snd_usb_endpoint_sync_pending_stop(struct snd_usb_endpoint *ep); void snd_usb_endpoint_sync_pending_stop(struct snd_usb_endpoint *ep);
int snd_usb_endpoint_activate(struct snd_usb_endpoint *ep); int snd_usb_endpoint_activate(struct snd_usb_endpoint *ep);
int snd_usb_endpoint_deactivate(struct snd_usb_endpoint *ep); void snd_usb_endpoint_deactivate(struct snd_usb_endpoint *ep);
void snd_usb_endpoint_free(struct list_head *head); void snd_usb_endpoint_free(struct list_head *head);
int snd_usb_endpoint_implicit_feedback_sink(struct snd_usb_endpoint *ep); int snd_usb_endpoint_implicit_feedback_sink(struct snd_usb_endpoint *ep);