rtc: rx8025: protect ctrl1 register update by rtc->ops_lock
The ctrl1 register is accessed by alarm operations. But it is updated in threaded interrupt handler without acquiring rtc->ops_lock. Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Cc: Wolfgang Grandegger <wg@grandegger.com> Cc: Alessandro Zummo <a.zummo@towertech.it> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
This commit is contained in:
parent
0a966c0732
commit
9dbe385296
|
@ -146,8 +146,10 @@ static irqreturn_t rx8025_handle_irq(int irq, void *dev_id)
|
||||||
{
|
{
|
||||||
struct i2c_client *client = dev_id;
|
struct i2c_client *client = dev_id;
|
||||||
struct rx8025_data *rx8025 = i2c_get_clientdata(client);
|
struct rx8025_data *rx8025 = i2c_get_clientdata(client);
|
||||||
|
struct mutex *lock = &rx8025->rtc->ops_lock;
|
||||||
int status;
|
int status;
|
||||||
|
|
||||||
|
mutex_lock(lock);
|
||||||
status = rx8025_read_reg(client, RX8025_REG_CTRL2);
|
status = rx8025_read_reg(client, RX8025_REG_CTRL2);
|
||||||
if (status < 0)
|
if (status < 0)
|
||||||
goto out;
|
goto out;
|
||||||
|
@ -172,6 +174,8 @@ static irqreturn_t rx8025_handle_irq(int irq, void *dev_id)
|
||||||
}
|
}
|
||||||
|
|
||||||
out:
|
out:
|
||||||
|
mutex_unlock(lock);
|
||||||
|
|
||||||
return IRQ_HANDLED;
|
return IRQ_HANDLED;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue