netfilter: only do skb_checksum_help on CHECKSUM_PARTIAL in ip_queue
While doing yet another audit on ip_summed I noticed ip_queue calling skb_checksum_help unnecessarily. As we will set ip_summed to CHECKSUM_NONE when necessary in ipq_mangle_ipv4, there is no need to zap CHECKSUM_COMPLETE in ipq_build_packet_message. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Patrick McHardy <kaber@trash.net>
This commit is contained in:
parent
3d91c1a848
commit
9e56c21486
|
@ -160,8 +160,7 @@ ipq_build_packet_message(struct nf_queue_entry *entry, int *errp)
|
||||||
break;
|
break;
|
||||||
|
|
||||||
case IPQ_COPY_PACKET:
|
case IPQ_COPY_PACKET:
|
||||||
if ((entry->skb->ip_summed == CHECKSUM_PARTIAL ||
|
if (entry->skb->ip_summed == CHECKSUM_PARTIAL &&
|
||||||
entry->skb->ip_summed == CHECKSUM_COMPLETE) &&
|
|
||||||
(*errp = skb_checksum_help(entry->skb))) {
|
(*errp = skb_checksum_help(entry->skb))) {
|
||||||
read_unlock_bh(&queue_lock);
|
read_unlock_bh(&queue_lock);
|
||||||
return NULL;
|
return NULL;
|
||||||
|
|
Loading…
Reference in a new issue