redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

nvram: Drop the bkl from non-generic nvram_llseek() 

Drop the bkl from nvram_llseek() as it obviously protects nothing.
The file offset is safe in essence.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <1255116426-7270-1-git-send-email-fweisbec@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
wifi-calibration
Frederic Weisbecker 2009-10-09 21:27:06 +02:00 committed by Thomas Gleixner
parent 6783b9cd71
commit 9e8ab74dda
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/char/nvram.c
View File

@ -38,7 +38,6 @@
#define NVRAM_VERSION "1.3"
#include <linux/module.h>
#include <linux/smp_lock.h>
#include <linux/nvram.h>
#define PC 1
@ -214,7 +213,6 @@ void nvram_set_checksum(void)
static loff_t nvram_llseek(struct file *file, loff_t offset, int origin)
{
lock_kernel();
switch (origin) {
case 0:
/* nothing to do */
@ -226,7 +224,7 @@ static loff_t nvram_llseek(struct file *file, loff_t offset, int origin)
offset += NVRAM_BYTES;
break;
}
unlock_kernel();
return (offset >= 0) ? (file->f_pos = offset) : -EINVAL;
}