redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

Staging: intel_sst: off by one bug 

This should be >= instead of > or we go passed the end of the array.

Also the arrays are declared with size MAX_NUM_STREAMS.  This is the
only place that uses MAX_NUM_STREAMS_MFLD.  It seems like asking for
trouble to use two variables for the same information.  I've changed
everything to use MAX_NUM_STREAMS.

This bug isn't really harmful.  In the worst case, if you enabled
debugging then you would see a message.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
wifi-calibration
Dan Carpenter 2010-10-15 22:36:48 +02:00 committed by Greg Kroah-Hartman
parent 87b554a04a
commit 9f407840bb
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/staging/intel_sst/intel_sst_fw_ipc.h
View File

@ -31,7 +31,6 @@
*/
#define MAX_NUM_STREAMS_MRST 3
#define MAX_NUM_STREAMS_MFLD 6
#define MAX_NUM_STREAMS 6
#define MAX_DBG_RW_BYTES 80
#define MAX_NUM_SCATTER_BUFFERS 8

2
drivers/staging/intel_sst/intel_sst_stream.c
View File

@ -45,7 +45,7 @@
*/
int sst_check_device_type(u32 device, u32 num_chan, u32 *pcm_slot)
{
if (device > MAX_NUM_STREAMS_MFLD) {
if (device >= MAX_NUM_STREAMS) {
pr_debug("sst: device type invalid %d\n", device);
return -EINVAL;
}