staging: tidspbridge: remove dev_init() and dev_exit()
The dev module has a dev_init() and a dev_exit() whose only purpose is to keep a reference counting which is not used at all. This patch removes these functions and the reference count variable. There is no functional changes. Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
d071c0e9ca
commit
a05c5dc3fc
|
@ -477,33 +477,6 @@ extern int dev_get_bridge_context(struct dev_object *hdev_obj,
|
||||||
struct bridge_dev_context
|
struct bridge_dev_context
|
||||||
**phbridge_context);
|
**phbridge_context);
|
||||||
|
|
||||||
/*
|
|
||||||
* ======== dev_exit ========
|
|
||||||
* Purpose:
|
|
||||||
* Decrement reference count, and free resources when reference count is
|
|
||||||
* 0.
|
|
||||||
* Parameters:
|
|
||||||
* Returns:
|
|
||||||
* Requires:
|
|
||||||
* DEV is initialized.
|
|
||||||
* Ensures:
|
|
||||||
* When reference count == 0, DEV's private resources are freed.
|
|
||||||
*/
|
|
||||||
extern void dev_exit(void);
|
|
||||||
|
|
||||||
/*
|
|
||||||
* ======== dev_init ========
|
|
||||||
* Purpose:
|
|
||||||
* Initialize DEV's private state, keeping a reference count on each call.
|
|
||||||
* Parameters:
|
|
||||||
* Returns:
|
|
||||||
* TRUE if initialized; FALSE if error occurred.
|
|
||||||
* Requires:
|
|
||||||
* Ensures:
|
|
||||||
* TRUE: A requirement for the other public DEV functions.
|
|
||||||
*/
|
|
||||||
extern bool dev_init(void);
|
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* ======== dev_insert_proc_object ========
|
* ======== dev_insert_proc_object ========
|
||||||
* Purpose:
|
* Purpose:
|
||||||
|
|
|
@ -81,9 +81,6 @@ struct drv_ext {
|
||||||
char sz_string[MAXREGPATHLENGTH];
|
char sz_string[MAXREGPATHLENGTH];
|
||||||
};
|
};
|
||||||
|
|
||||||
/* ----------------------------------- Globals */
|
|
||||||
static u32 refs; /* Module reference count */
|
|
||||||
|
|
||||||
/* ----------------------------------- Function Prototypes */
|
/* ----------------------------------- Function Prototypes */
|
||||||
static int fxn_not_implemented(int arg, ...);
|
static int fxn_not_implemented(int arg, ...);
|
||||||
static int init_cod_mgr(struct dev_object *dev_obj);
|
static int init_cod_mgr(struct dev_object *dev_obj);
|
||||||
|
@ -648,32 +645,6 @@ int dev_get_bridge_context(struct dev_object *hdev_obj,
|
||||||
return status;
|
return status;
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
|
||||||
* ======== dev_exit ========
|
|
||||||
* Purpose:
|
|
||||||
* Decrement reference count, and free resources when reference count is
|
|
||||||
* 0.
|
|
||||||
*/
|
|
||||||
void dev_exit(void)
|
|
||||||
{
|
|
||||||
refs--;
|
|
||||||
}
|
|
||||||
|
|
||||||
/*
|
|
||||||
* ======== dev_init ========
|
|
||||||
* Purpose:
|
|
||||||
* Initialize DEV's private state, keeping a reference count on each call.
|
|
||||||
*/
|
|
||||||
bool dev_init(void)
|
|
||||||
{
|
|
||||||
bool ret = true;
|
|
||||||
|
|
||||||
if (ret)
|
|
||||||
refs++;
|
|
||||||
|
|
||||||
return ret;
|
|
||||||
}
|
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* ======== dev_notify_clients ========
|
* ======== dev_notify_clients ========
|
||||||
* Purpose:
|
* Purpose:
|
||||||
|
|
|
@ -265,11 +265,8 @@ void api_exit(void)
|
||||||
{
|
{
|
||||||
api_c_refs--;
|
api_c_refs--;
|
||||||
|
|
||||||
if (api_c_refs == 0) {
|
if (api_c_refs == 0)
|
||||||
/* Release all modules initialized in api_init(). */
|
|
||||||
dev_exit();
|
|
||||||
mgr_exit();
|
mgr_exit();
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
|
@ -280,23 +277,10 @@ void api_exit(void)
|
||||||
bool api_init(void)
|
bool api_init(void)
|
||||||
{
|
{
|
||||||
bool ret = true;
|
bool ret = true;
|
||||||
bool fdev;
|
|
||||||
bool fmgr;
|
|
||||||
|
|
||||||
if (api_c_refs == 0) {
|
if (api_c_refs == 0)
|
||||||
/* initialize driver and other modules */
|
ret = mgr_init();
|
||||||
fmgr = mgr_init();
|
|
||||||
fdev = dev_init();
|
|
||||||
ret = fdev && fmgr;
|
|
||||||
if (!ret) {
|
|
||||||
|
|
||||||
if (fmgr)
|
|
||||||
mgr_exit();
|
|
||||||
|
|
||||||
if (fdev)
|
|
||||||
dev_exit();
|
|
||||||
}
|
|
||||||
}
|
|
||||||
if (ret)
|
if (ret)
|
||||||
api_c_refs++;
|
api_c_refs++;
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue