iscsi-target: fix memory leak in iscsit_release_discovery_tpg()
Need to release the param_list for tpg in iscsi_release_discovery_tpg function, this is also required before the iscsit_load_discovery_tpg function exits abnormally. Signed-off-by: tangwenji <tang.wenji@zte.com.cn> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
parent
12d5a43b2d
commit
a0884d489e
|
@ -90,10 +90,10 @@ int iscsit_load_discovery_tpg(void)
|
|||
*/
|
||||
param = iscsi_find_param_from_key(AUTHMETHOD, tpg->param_list);
|
||||
if (!param)
|
||||
goto out;
|
||||
goto free_pl_out;
|
||||
|
||||
if (iscsi_update_param_value(param, "CHAP,None") < 0)
|
||||
goto out;
|
||||
goto free_pl_out;
|
||||
|
||||
tpg->tpg_attrib.authentication = 0;
|
||||
|
||||
|
@ -105,6 +105,8 @@ int iscsit_load_discovery_tpg(void)
|
|||
pr_debug("CORE[0] - Allocated Discovery TPG\n");
|
||||
|
||||
return 0;
|
||||
free_pl_out:
|
||||
iscsi_release_param_list(tpg->param_list);
|
||||
out:
|
||||
if (tpg->sid == 1)
|
||||
core_tpg_deregister(&tpg->tpg_se_tpg);
|
||||
|
@ -119,6 +121,7 @@ void iscsit_release_discovery_tpg(void)
|
|||
if (!tpg)
|
||||
return;
|
||||
|
||||
iscsi_release_param_list(tpg->param_list);
|
||||
core_tpg_deregister(&tpg->tpg_se_tpg);
|
||||
|
||||
kfree(tpg);
|
||||
|
|
Loading…
Reference in a new issue