redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

batman-adv: Remove unnecessary check for orig_ifinfo not NULL

Browse source 
orig_ifinfo is dereferenced multiple times in batadv_iv_ogm_update_seqnos
before the check for NULL is done. The function also exists at the
beginning when orig_ifinfo would have been NULL. This makes the check at
the end unnecessary and only confuses the reader/code analyzers.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
This commit is contained in:
Sven Eckelmann 2015-03-01 16:56:26 +01:00 committed by Antonio Quartulli
parent 21102626da
commit a0c77227ff
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
net/batman-adv/bat_iv_ogm.c
View file

@ -1357,8 +1357,7 @@ batadv_iv_ogm_update_seqnos(const struct ethhdr *ethhdr,
out:
spin_unlock_bh(&orig_node->bat_iv.ogm_cnt_lock);
batadv_orig_node_free_ref(orig_node);
if (orig_ifinfo)
batadv_orig_ifinfo_free_ref(orig_ifinfo);
batadv_orig_ifinfo_free_ref(orig_ifinfo);
return ret;
}