ipack/devices/ipoctal: avoid re-enable RX two times.
RX is enabled when the tty port is open, so no need to do it in initialization time: it can allow the device to receive characters but no TTY client is listening to them. It produced an infinite number of IRQ as RxFIFO is not read to clear that IRQ in the device, so it is still pending. Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
9d01b6f064
commit
a3882b7814
|
@ -60,6 +60,10 @@ static int ipoctal_port_activate(struct tty_port *port, struct tty_struct *tty)
|
|||
|
||||
channel = dev_get_drvdata(tty->dev);
|
||||
|
||||
/*
|
||||
* Enable RX. TX will be enabled when
|
||||
* there is something to send
|
||||
*/
|
||||
iowrite8(CR_ENABLE_RX, &channel->regs->w.cr);
|
||||
return 0;
|
||||
}
|
||||
|
@ -385,12 +389,6 @@ static int ipoctal_inst_slot(struct ipoctal *ipoctal, unsigned int bus_nr,
|
|||
continue;
|
||||
}
|
||||
dev_set_drvdata(tty_dev, channel);
|
||||
|
||||
/*
|
||||
* Enable again the RX. TX will be enabled when
|
||||
* there is something to send
|
||||
*/
|
||||
iowrite8(CR_ENABLE_RX, &channel->regs->w.cr);
|
||||
}
|
||||
|
||||
return 0;
|
||||
|
|
Loading…
Reference in a new issue