smc91x: improve definition of debug macros
Redefine some macros that were conditioned upon SMC_DEBUG level. By allowing compiler to verify parameters used by these macros unconditionally, we can flag compilation failures. Compiler will still optimize out the unused code path depending on SMC_DEBUG, so this is a net gain. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Zi Shen Lim <zlim.lnx@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
83d5b7ef99
commit
a450a68579
|
@ -147,18 +147,19 @@ MODULE_ALIAS("platform:smc91x");
|
|||
*/
|
||||
#define MII_DELAY 1
|
||||
|
||||
#if SMC_DEBUG > 0
|
||||
#define DBG(n, dev, args...) \
|
||||
do { \
|
||||
if (SMC_DEBUG >= (n)) \
|
||||
netdev_dbg(dev, args); \
|
||||
#define DBG(n, dev, fmt, ...) \
|
||||
do { \
|
||||
if (SMC_DEBUG >= (n)) \
|
||||
netdev_dbg(dev, fmt, ##__VA_ARGS__); \
|
||||
} while (0)
|
||||
|
||||
#define PRINTK(dev, args...) netdev_info(dev, args)
|
||||
#else
|
||||
#define DBG(n, dev, args...) do { } while (0)
|
||||
#define PRINTK(dev, args...) netdev_dbg(dev, args)
|
||||
#endif
|
||||
#define PRINTK(dev, fmt, ...) \
|
||||
do { \
|
||||
if (SMC_DEBUG > 0) \
|
||||
netdev_info(dev, fmt, ##__VA_ARGS__); \
|
||||
else \
|
||||
netdev_dbg(dev, fmt, ##__VA_ARGS__); \
|
||||
} while (0)
|
||||
|
||||
#if SMC_DEBUG > 3
|
||||
static void PRINT_PKT(u_char *buf, int length)
|
||||
|
@ -191,7 +192,7 @@ static void PRINT_PKT(u_char *buf, int length)
|
|||
pr_cont("\n");
|
||||
}
|
||||
#else
|
||||
#define PRINT_PKT(x...) do { } while (0)
|
||||
static inline void PRINT_PKT(u_char *buf, int length) { }
|
||||
#endif
|
||||
|
||||
|
||||
|
|
Loading…
Reference in a new issue