redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

staging: cxt1e1: use kernel's way of returning error codes

Browse source 
The error codes the kernel functions return are -ve numbers, convert this
function to follow the other kernel functions

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Devendra Naga 2012-09-02 02:29:50 +05:30 committed by Greg Kroah-Hartman
parent 375d8886bc
commit a47bf2452b
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/staging/cxt1e1/linux.c
View file

@ -405,7 +405,7 @@ c4_linux_xmit (struct sk_buff * skb, struct net_device * ndev)
priv = hdlc->priv;
rval = musycc_start_xmit (priv->ci, priv->channum, skb);
return -rval;
return rval;
}
static const struct net_device_ops chan_ops = {

10
drivers/staging/cxt1e1/musycc.c
View file

@ -1761,15 +1761,15 @@ musycc_start_xmit (ci_t * ci, int channum, void *mem_token)
u_int32_t len;
if (!(ch = sd_find_chan (ci, channum)))
return ENOENT;
return -ENOENT;
if (ci->state != C_RUNNING) /* full interrupt processing available */
return EINVAL;
return -EINVAL;
if (ch->state != UP)
return EINVAL;
return -EINVAL;
if (!(ch->status & TX_ENABLED))
return EROFS; /* how else to flag unwritable state ? */
return -EROFS; /* how else to flag unwritable state ? */
#ifdef RLD_TRANS_DEBUGx
if (1 || cxt1e1_log_level >= LOG_MONITOR2)
@ -1836,7 +1836,7 @@ musycc_start_xmit (ci_t * ci, int channum, void *mem_token)
#if 0
spin_unlock_irqrestore (&ch->ch_txlock, flags);
#endif
return EBUSY; /* tell user to try again later */
return -EBUSY; /* tell user to try again later */
}
/**************************************************/
/** Put the user data into MUSYCC data buffer(s) **/