redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

ALSA: line6: fix ifnullfree.cocci warnings

Browse source 
sound/usb/line6/driver.c:484:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Andrej Krutak <dev@andree.sk>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
kbuild test robot 2016-09-20 08:10:13 +08:00 committed by Takashi Iwai
parent a16039cbf1
commit a4bc746c41
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
sound/usb/line6/driver.c
View file

@ -480,8 +480,7 @@ static void line6_destruct(struct snd_card *card)
/* Free buffer memory first. We cannot depend on the existence of private /* Free buffer memory first. We cannot depend on the existence of private
* data from the (podhd) module, it may be gone already during this call * data from the (podhd) module, it may be gone already during this call
*/ */
if (line6->buffer_message) kfree(line6->buffer_message);
kfree(line6->buffer_message);
kfree(line6->buffer_listen); kfree(line6->buffer_listen);