redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

[PATCH] I2C: #include <linux/config.h> cleanup 

Hi Alexey,

> Files that don't use CONFIG_* stuff shouldn't include config.h
> Files that use CONFIG_* stuff should include config.h
>
> It's that simple. ;-)

I agree. This won't change anything though, as all drivers include
either device.h or module.h, which in turn include config.h. But you are
still correct, so I approve your patch.

For completeness, I would propose the following on top of your own
patch:

i2c bus drivers do not need to define DEBUG themselves, as the Kconfig
system takes care of it.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
5bit-waveforms
Jean Delvare 2005-04-16 18:49:22 +02:00 committed by Greg Kroah-Hartman
parent f0bb60e7b1
commit a551ef79d9
2 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/i2c/busses/i2c-ixp2000.c
View File

@ -26,11 +26,6 @@
* 'enabled' to drive the GPIOs.
*/
#include <linux/config.h>
#ifdef CONFIG_I2C_DEBUG_BUS
#define DEBUG 1
#endif
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/device.h>

5
drivers/i2c/busses/i2c-ixp4xx.c
View File

@ -26,11 +26,6 @@
* that is passed as the platform_data to this driver.
*/
#include <linux/config.h>
#ifdef CONFIG_I2C_DEBUG_BUS
#define DEBUG 1
#endif
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/device.h>