net: correct check in dev_addr_del()
Check (ha->addr == dev->dev_addr) is always true because dev_addr_init() sets this. Correct the check to behave properly on addr removal. Signed-off-by: Jiri Pirko <jiri@resnulli.us> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
ec34232575
commit
a652208e0b
|
@ -319,7 +319,8 @@ int dev_addr_del(struct net_device *dev, const unsigned char *addr,
|
||||||
*/
|
*/
|
||||||
ha = list_first_entry(&dev->dev_addrs.list,
|
ha = list_first_entry(&dev->dev_addrs.list,
|
||||||
struct netdev_hw_addr, list);
|
struct netdev_hw_addr, list);
|
||||||
if (ha->addr == dev->dev_addr && ha->refcount == 1)
|
if (!memcmp(ha->addr, addr, dev->addr_len) &&
|
||||||
|
ha->type == addr_type && ha->refcount == 1)
|
||||||
return -ENOENT;
|
return -ENOENT;
|
||||||
|
|
||||||
err = __hw_addr_del(&dev->dev_addrs, addr, dev->addr_len,
|
err = __hw_addr_del(&dev->dev_addrs, addr, dev->addr_len,
|
||||||
|
|
Loading…
Reference in a new issue