x86/platform/quark: Re-use DEFINE_SHOW_ATTRIBUTE() macro
...instead of open coding file operations followed by custom ->open() callbacks per each attribute. While here, replace permissions by explicit octal value. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/20180214154317.52290-2-andriy.shevchenko@linux.intel.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
parent
3130451e27
commit
a66b86f002
|
@ -224,25 +224,7 @@ static int imr_dbgfs_state_show(struct seq_file *s, void *unused)
|
|||
mutex_unlock(&idev->lock);
|
||||
return ret;
|
||||
}
|
||||
|
||||
/**
|
||||
* imr_state_open - debugfs open callback.
|
||||
*
|
||||
* @inode: pointer to struct inode.
|
||||
* @file: pointer to struct file.
|
||||
* @return: result of single open.
|
||||
*/
|
||||
static int imr_state_open(struct inode *inode, struct file *file)
|
||||
{
|
||||
return single_open(file, imr_dbgfs_state_show, inode->i_private);
|
||||
}
|
||||
|
||||
static const struct file_operations imr_state_ops = {
|
||||
.open = imr_state_open,
|
||||
.read = seq_read,
|
||||
.llseek = seq_lseek,
|
||||
.release = single_release,
|
||||
};
|
||||
DEFINE_SHOW_ATTRIBUTE(imr_dbgfs_state);
|
||||
|
||||
/**
|
||||
* imr_debugfs_register - register debugfs hooks.
|
||||
|
@ -252,8 +234,8 @@ static const struct file_operations imr_state_ops = {
|
|||
*/
|
||||
static int imr_debugfs_register(struct imr_device *idev)
|
||||
{
|
||||
idev->file = debugfs_create_file("imr_state", S_IFREG | S_IRUGO, NULL,
|
||||
idev, &imr_state_ops);
|
||||
idev->file = debugfs_create_file("imr_state", 0444, NULL, idev,
|
||||
&imr_dbgfs_state_fops);
|
||||
return PTR_ERR_OR_ZERO(idev->file);
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue