redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

Platform: Fix error path in samsung-laptop init

Browse source 
samsung_init() should not return success if not all devices are initialized.
Otherwise, samsung_exit() will dereference sdev NULL pointers and others.

Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
This commit is contained in:
David Herrmann 2011-09-20 09:16:12 -07:00 committed by Matthew Garrett
parent bee460be8c
commit a7ea19926f
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/platform/x86/samsung-laptop.c
View file

@ -781,7 +781,7 @@ static int __init samsung_init(void)
sabi_iface = ioremap_nocache(ifaceP, 16); sabi_iface = ioremap_nocache(ifaceP, 16);
if (!sabi_iface) { if (!sabi_iface) {
pr_err("Can't remap %x\n", ifaceP); pr_err("Can't remap %x\n", ifaceP);
goto exit; goto error_no_signature;
} }
if (debug) { if (debug) {
printk(KERN_DEBUG "ifaceP = 0x%08x\n", ifaceP); printk(KERN_DEBUG "ifaceP = 0x%08x\n", ifaceP);
@ -833,7 +833,6 @@ static int __init samsung_init(void)
if (retval) if (retval)
goto error_file_create; goto error_file_create;
exit:
return 0; return 0;
error_file_create: error_file_create: