redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

[media] ttpci: cleanup debug macros and remove dead code 

Continuation lines without KERN_CONT won't work anymore.
However, the way dprintk() was defined leads to the usage
of continuation lines, with should be avoided when possible.

So, redefine those macros.

While hre, remove some dead code at av7110.c with also
relies on continuation lines.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
zero-colors
Mauro Carvalho Chehab 2016-10-14 07:58:43 -03:00
parent 61fc87498b
commit a80e1d965c
3 changed files with 11 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/media/pci/ttpci/av7110.c
View File

@ -443,21 +443,6 @@ static void debiirq(unsigned long cookie)
case DATA_COMMON_INTERFACE:
CI_handle(av7110, (u8 *)av7110->debi_virt, av7110->debilen);
#if 0
{
int i;
printk("av7110%d: ", av7110->num);
printk("%02x ", *(u8 *)av7110->debi_virt);
printk("%02x ", *(1+(u8 *)av7110->debi_virt));
for (i = 2; i < av7110->debilen; i++)
printk("%02x ", (*(i+(unsigned char *)av7110->debi_virt)));
for (i = 2; i < av7110->debilen; i++)
printk("%c", chtrans(*(i+(unsigned char *)av7110->debi_virt)));
printk("\n");
}
#endif
xfer = RX_BUFF;
break;

7
drivers/media/pci/ttpci/av7110.h
View File

@ -40,8 +40,11 @@
extern int av7110_debug;
#define dprintk(level,args...) \
do { if ((av7110_debug & level)) { printk("dvb-ttpci: %s(): ", __func__); printk(args); } } while (0)
#define dprintk(level, fmt, arg...) do { \
if (level & av7110_debug) \
printk(KERN_DEBUG KBUILD_MODNAME ": %s(): " fmt, \
__func__, ##arg); \
} while (0)
#define MAXFILT 32

8
drivers/media/pci/ttpci/budget.h
View File

@ -21,8 +21,12 @@ extern int budget_debug;
#undef dprintk
#endif
#define dprintk(level,args...) \
do { if ((budget_debug & level)) { printk("%s: %s(): ", KBUILD_MODNAME, __func__); printk(args); } } while (0)
#define dprintk(level, fmt, arg...) do { \
if (level & budget_debug) \
printk(KERN_DEBUG KBUILD_MODNAME ": %s(): " fmt, \
__func__, ##arg); \
} while (0)
struct budget_info {
char *name;