cifs: Fix check for regular file in couldbe_mf_symlink()
MF Symlinks are regular files containing content in a specified format. The function couldbe_mf_symlink() checks the mode for a set S_IFREG bit as a test to confirm that it is a regular file. This bit is also set for other filetypes and simply checking for this bit being set may return false positives. We ensure that we are actually checking for a regular file by using the S_ISREG macro to test instead. Signed-off-by: Sachin Prabhu <sprabhu@redhat.com> Reviewed-by: Jeff Layton <jlayton@redhat.com> Reported-by: Neil Brown <neilb@suse.de> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Steve French <smfrench@gmail.com>
This commit is contained in:
parent
666753c3ef
commit
a9a315d414
|
@ -185,7 +185,7 @@ format_mf_symlink(u8 *buf, unsigned int buf_len, const char *link_str)
|
||||||
bool
|
bool
|
||||||
couldbe_mf_symlink(const struct cifs_fattr *fattr)
|
couldbe_mf_symlink(const struct cifs_fattr *fattr)
|
||||||
{
|
{
|
||||||
if (!(fattr->cf_mode & S_IFREG))
|
if (!S_ISREG(fattr->cf_mode))
|
||||||
/* it's not a symlink */
|
/* it's not a symlink */
|
||||||
return false;
|
return false;
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue