redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

Input: cyttsp - remove useless checks in cyttsp_probe()

Browse source 
This fixes reference-before-check problem; there is no reason to check
if caller passed NULL dev or bus_ops as it is done only by bus-specific
drivers which already do the right thing.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
This commit is contained in:
Dmitry Torokhov 2012-03-04 09:26:15 -08:00
parent aa87512fbc
commit aaa60fa7ac
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/input/touchscreen/cyttsp_core.c
View file

@ -523,7 +523,7 @@ struct cyttsp *cyttsp_probe(const struct cyttsp_bus_ops *bus_ops,
struct input_dev *input_dev;
int error;
if (!dev || !bus_ops || !pdata || !pdata->name || irq <= 0) {
if (!pdata || !pdata->name || irq <= 0) {
error = -EINVAL;
goto err_out;
}