redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

[DRIVER MODEL] Fix gbefb

Browse source 
Statically allocated devices in module data is a potential cause
of oopsen.  The device may be in use by a userspace process, which
will keep a reference to the device.  If the module is unloaded,
the module data will be freed.  Subsequent use of the platform
device will cause a kernel oops.

Use generic platform device allocation/release code in modules.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Russell King 2005-11-05 21:22:13 +00:00 committed by Russell King
parent 8d972a9621
commit abbf268ae8
1 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
drivers/video/gbefb.c
View file

@ -1260,24 +1260,30 @@ static struct device_driver gbefb_driver = {
.remove = __devexit_p(gbefb_remove),
};
static struct platform_device gbefb_device = {
.name = "gbefb",
};
static struct platform_device *gbefb_device;
int __init gbefb_init(void)
{
int ret = driver_register(&gbefb_driver);
if (!ret) {
ret = platform_device_register(&gbefb_device);
if (ret)
gbefb_device = platform_device_alloc("gbefb", 0);
if (gbefb_device) {
ret = platform_device_add(gbefb_device);
} else {
ret = -ENOMEM;
}
if (ret) {
platform_device_put(gbefb_device);
driver_unregister(&gbefb_driver);
}
}
return ret;
}
void __exit gbefb_exit(void)
{
driver_unregister(&gbefb_driver);
platform_device_unregister(gbefb_device);
driver_unregister(&gbefb_driver);
}
module_init(gbefb_init);