From ac572452156963588b285049ba3895bef0f17642 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Thu, 23 Mar 2017 13:40:49 +0300 Subject: [PATCH] leds: mt6323: Fix an off by one bug in probe It should be ">= MT6323_MAX_LEDS" instead of ">". Also "reg" is a u32 so it can't be negative and we can remove the test for negative values. Fixes: 216ec6cc4c19 ("leds: Add LED support for MT6323 PMIC") Signed-off-by: Dan Carpenter Acked-by: Pavel Machek Signed-off-by: Jacek Anaszewski --- drivers/leds/leds-mt6323.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/leds-mt6323.c b/drivers/leds/leds-mt6323.c index 48081bccbea5..8893c74e9a1f 100644 --- a/drivers/leds/leds-mt6323.c +++ b/drivers/leds/leds-mt6323.c @@ -417,7 +417,7 @@ static int mt6323_led_probe(struct platform_device *pdev) goto put_child_node; } - if (reg < 0 || reg > MT6323_MAX_LEDS || leds->led[reg]) { + if (reg >= MT6323_MAX_LEDS || leds->led[reg]) { dev_err(dev, "Invalid led reg %u\n", reg); ret = -EINVAL; goto put_child_node;