redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

ipvlan: properly annotate rx_handler access 

The rx_handler field is rcu-protected, but I forgot to use the
proper accessor while refactoring netif_is_ipvlan_port(). Such
function only check the rx_handler value, so it is safe, but we need
to properly read rx_handler via rcu_access_pointer() to avoid sparse
warnings.

Fixes: 1ec54cb44e ("net: unpollute priv_flags space")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
zero-colors
Paolo Abeni 2018-03-08 10:29:30 +01:00 committed by David S. Miller
parent a366e300ae
commit ae5799dc7e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ipvlan/ipvlan.h
View File

@ -180,7 +180,7 @@ int ipvlan_link_register(struct rtnl_link_ops *ops);
static inline bool netif_is_ipvlan_port(const struct net_device *dev)
{
return dev->rx_handler == ipvlan_handle_frame;
return rcu_access_pointer(dev->rx_handler) == ipvlan_handle_frame;
}
#endif /* __IPVLAN_H */