sched/cpufreq: Annotate cpufreq_update_util_data pointer with __rcu
Recently I added an RCU annotation check to rcu_assign_pointer(). All pointers assigned to RCU protected data are to be annotated with __rcu inorder to be able to use rcu_assign_pointer() similar to checks in other RCU APIs. This resulted in a sparse error: kernel//sched/cpufreq.c:41:9: sparse: error: incompatible types in comparison expression (different address spaces) Fix this by annotating cpufreq_update_util_data pointer with __rcu. This will also help sparse catch any future RCU misuage bugs. Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> [ From an RCU perspective. ] Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Paul E. McKenney <paulmck@linux.ibm.com> Cc: Josh Triplett <josh@joshtriplett.org> Cc: Lai Jiangshan <jiangshanlai@gmail.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Morten Rasmussen <morten.rasmussen@arm.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: keescook@chromium.org Cc: kernel-hardening@lists.openwall.com Cc: kernel-team@android.com Link: https://lkml.kernel.org/r/20190321003426.160260-2-joel@joelfernandes.org Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
parent
0e9f02450d
commit
b10abd0a88
|
@ -7,7 +7,7 @@
|
||||||
*/
|
*/
|
||||||
#include "sched.h"
|
#include "sched.h"
|
||||||
|
|
||||||
DEFINE_PER_CPU(struct update_util_data *, cpufreq_update_util_data);
|
DEFINE_PER_CPU(struct update_util_data __rcu *, cpufreq_update_util_data);
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* cpufreq_add_update_util_hook - Populate the CPU's update_util_data pointer.
|
* cpufreq_add_update_util_hook - Populate the CPU's update_util_data pointer.
|
||||||
|
|
|
@ -2185,7 +2185,7 @@ static inline u64 irq_time_read(int cpu)
|
||||||
#endif /* CONFIG_IRQ_TIME_ACCOUNTING */
|
#endif /* CONFIG_IRQ_TIME_ACCOUNTING */
|
||||||
|
|
||||||
#ifdef CONFIG_CPU_FREQ
|
#ifdef CONFIG_CPU_FREQ
|
||||||
DECLARE_PER_CPU(struct update_util_data *, cpufreq_update_util_data);
|
DECLARE_PER_CPU(struct update_util_data __rcu *, cpufreq_update_util_data);
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* cpufreq_update_util - Take a note about CPU utilization changes.
|
* cpufreq_update_util - Take a note about CPU utilization changes.
|
||||||
|
|
Loading…
Reference in a new issue