mac80211: check for allocation failure in debugfs code
kmalloc() can fail. Also let's move the allocation out of the
declaration block so it's easier to read.
Fixes: 4a5eccaa93
("mac80211: Show pending txqlen in debugfs.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
zero-colors
parent
26717828b7
commit
b2347a322d
|
@ -249,12 +249,19 @@ static ssize_t misc_read(struct file *file, char __user *user_buf,
|
||||||
struct ieee80211_local *local = file->private_data;
|
struct ieee80211_local *local = file->private_data;
|
||||||
/* Max len of each line is 16 characters, plus 9 for 'pending:\n' */
|
/* Max len of each line is 16 characters, plus 9 for 'pending:\n' */
|
||||||
size_t bufsz = IEEE80211_MAX_QUEUES * 16 + 9;
|
size_t bufsz = IEEE80211_MAX_QUEUES * 16 + 9;
|
||||||
char *buf = kzalloc(bufsz, GFP_KERNEL);
|
char *buf;
|
||||||
char *pos = buf, *end = buf + bufsz - 1;
|
char *pos, *end;
|
||||||
ssize_t rv;
|
ssize_t rv;
|
||||||
int i;
|
int i;
|
||||||
int ln;
|
int ln;
|
||||||
|
|
||||||
|
buf = kzalloc(bufsz, GFP_KERNEL);
|
||||||
|
if (!buf)
|
||||||
|
return -ENOMEM;
|
||||||
|
|
||||||
|
pos = buf;
|
||||||
|
end = buf + bufsz - 1;
|
||||||
|
|
||||||
pos += scnprintf(pos, end - pos, "pending:\n");
|
pos += scnprintf(pos, end - pos, "pending:\n");
|
||||||
|
|
||||||
for (i = 0; i < IEEE80211_MAX_QUEUES; i++) {
|
for (i = 0; i < IEEE80211_MAX_QUEUES; i++) {
|
||||||
|
|
Loading…
Reference in New Issue