kbuild: add %.lex.c and %.tab.[ch] to 'targets' automatically
Files generated by if_changed* must be added to 'targets' to include *.cmd files. Otherwise, they would be regenerated every time. The build system automatically adds objects to 'targets' where appropriate, such as obj-y, extra-y, etc. but does nothing for intermediate files. So, each Makefile needs to add them by itself. There are some common cases where objects are generated by chained rules. Lexers and parsers are compiled like follows: %.lex.o <- %.lex.c <- %.l %.tab.o <- %.tab.c <- %.y They are common patterns, so it is reasonable to take care of them in the core Makefile instead of requiring each Makefile to do so. At this moment, you cannot delete 'target += zconf.lex.c' in the Kconfig Makefile because zconf.lex.c is included from zconf.tab.c instead of being compiled separately. It should be deleted after Kconfig is more refactored. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Acked-by: Frank Rowand <frowand.list@gmail.com>
This commit is contained in:
parent
833e622459
commit
b23d1a241f
|
@ -538,6 +538,17 @@ $(call multi_depend, $(multi-used-m), .o, -objs -y -m)
|
||||||
targets += $(multi-used-m)
|
targets += $(multi-used-m)
|
||||||
targets := $(filter-out $(PHONY), $(targets))
|
targets := $(filter-out $(PHONY), $(targets))
|
||||||
|
|
||||||
|
# Add intermediate targets:
|
||||||
|
# When building objects with specific suffix patterns, add intermediate
|
||||||
|
# targets that the final targets are derived from.
|
||||||
|
intermediate_targets = $(foreach sfx, $(2), \
|
||||||
|
$(patsubst %$(strip $(1)),%$(sfx), \
|
||||||
|
$(filter %$(strip $(1)), $(targets))))
|
||||||
|
# %.lex.o <- %.lex.c <- %.l
|
||||||
|
# %.tab.o <- %.tab.[ch] <- %.y
|
||||||
|
targets += $(call intermediate_targets, .lex.o, .lex.c) \
|
||||||
|
$(call intermediate_targets, .tab.o, .tab.c .tab.h)
|
||||||
|
|
||||||
# Descending
|
# Descending
|
||||||
# ---------------------------------------------------------------------------
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
|
@ -27,6 +27,3 @@ HOSTCFLAGS_dtc-parser.tab.o := $(HOSTCFLAGS_DTC)
|
||||||
|
|
||||||
# dependencies on generated files need to be listed explicitly
|
# dependencies on generated files need to be listed explicitly
|
||||||
$(obj)/dtc-lexer.lex.o: $(obj)/dtc-parser.tab.h
|
$(obj)/dtc-lexer.lex.o: $(obj)/dtc-parser.tab.h
|
||||||
|
|
||||||
# generated files need to include *.cmd
|
|
||||||
targets := dtc-lexer.lex.c dtc-parser.tab.c dtc-parser.tab.h
|
|
||||||
|
|
|
@ -36,5 +36,3 @@ HOSTCFLAGS_lex.lex.o := -I$(src)
|
||||||
|
|
||||||
# dependencies on generated files need to be listed explicitly
|
# dependencies on generated files need to be listed explicitly
|
||||||
$(obj)/lex.lex.o: $(obj)/parse.tab.h
|
$(obj)/lex.lex.o: $(obj)/parse.tab.h
|
||||||
|
|
||||||
targets := lex.lex.c parse.tab.c parse.tab.h
|
|
||||||
|
|
|
@ -207,7 +207,7 @@ gconf-objs := gconf.o zconf.tab.o
|
||||||
|
|
||||||
hostprogs-y := conf nconf mconf kxgettext qconf gconf
|
hostprogs-y := conf nconf mconf kxgettext qconf gconf
|
||||||
|
|
||||||
targets += zconf.tab.c zconf.lex.c
|
targets += zconf.lex.c
|
||||||
clean-files := qconf.moc .tmp_qtcheck .tmp_gtkcheck
|
clean-files := qconf.moc .tmp_qtcheck .tmp_gtkcheck
|
||||||
clean-files += gconf.glade.h
|
clean-files += gconf.glade.h
|
||||||
clean-files += config.pot linux.pot
|
clean-files += config.pot linux.pot
|
||||||
|
|
Loading…
Reference in a new issue