redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

powerpc/perf: Fix double unlock in imc_common_cpuhp_mem_free() 

This function is not called with the nest_init_lock held, and it also
unlocks the nest_init_lock immediately below, so it's fairly clear
that this is a typo and should be locking the lock.

Fixes: 885dcd709b ("powerpc/perf: Add nest IMC PMU support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
zero-colors
Dan Carpenter 2017-08-11 23:05:41 +03:00 committed by Michael Ellerman
parent ab2675d6ac
commit b3376dcc6c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/powerpc/perf/imc-pmu.c
View File

@ -1124,7 +1124,7 @@ static void cleanup_all_thread_imc_memory(void)
static void imc_common_cpuhp_mem_free(struct imc_pmu *pmu_ptr)
{
if (pmu_ptr->domain == IMC_DOMAIN_NEST) {
mutex_unlock(&nest_init_lock);
mutex_lock(&nest_init_lock);
if (nest_pmus == 1) {
cpuhp_remove_state(CPUHP_AP_PERF_POWERPC_NEST_IMC_ONLINE);
kfree(nest_imc_refc);