redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

rxrpc: Accesses of rxrpc_local::service need to be RCU managed

Browse source 
struct rxrpc_local->service is marked __rcu - this means that accesses of
it need to be managed using RCU wrappers.  There are two such places in
rxrpc_release_sock() where the value is checked and cleared.  Fix this by
using the appropriate wrappers.

Signed-off-by: David Howells <dhowells@redhat.com>
This commit is contained in:
David Howells 2016-10-06 08:11:48 +01:00
parent af70c1f92d
commit b63452c11e
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
net/rxrpc/af_rxrpc.c
View file

@ -678,9 +678,9 @@ static int rxrpc_release_sock(struct sock *sk)
sk->sk_state = RXRPC_CLOSE;
spin_unlock_bh(&sk->sk_receive_queue.lock);
if (rx->local && rx->local->service == rx) {
if (rx->local && rcu_access_pointer(rx->local->service) == rx) {
write_lock(&rx->local->services_lock);
rx->local->service = NULL;
rcu_assign_pointer(rx->local->service, NULL);
write_unlock(&rx->local->services_lock);
}