redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

MLK-11911-1 mxc IPUv3: capture: Define div_ratio as type of int32_t 

The local variable div_ratio could be less than zero, so let's define
it as type of int32_t instead of uint32_t.

This issue is reported by Coverity:
Unsigned compared against 0 (NO_EFFECT)
unsigned_compare: This less-than-zero comparison of an unsigned value
is never true. div_ratio < 0U.
	if (div_ratio > 0xFF || div_ratio < 0) {
		dev_dbg(ipu->dev, "value of pixel_clk extends normal range\n");
		return -EINVAL;
	}

Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
pull/10/head
Liu Ying 2015-11-26 15:28:36 +08:00 committed by Jason Liu
parent 1a27aaad0b
commit b971b58f48
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/mxc/ipu3/ipu_capture.c
View File

@ -43,7 +43,7 @@
int _ipu_csi_mclk_set(struct ipu_soc *ipu, uint32_t pixel_clk, uint32_t csi)
{
uint32_t temp;
uint32_t div_ratio;
int32_t div_ratio;
div_ratio = (clk_get_rate(ipu->ipu_clk) / pixel_clk) - 1;