redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

xattr: mark variable as uninitialized to make both gcc and smatch happy 

new_xattr in __simple_xattr_set() is only initialized with a valid
pointer if value is not NULL, which only happens if this function is
called directly with the intention to remove an existing extended
attribute. Even being safe to be this way, smatch warns about possible
NULL dereference. Dan Carpenter suggested using uninitialized_var()
which will make both gcc and smatch happy.

Cc: Fengguang Wu <fengguang.wu@intel.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Aristeu Rozanski <aris@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
wifi-calibration
Aristeu Rozanski 2012-09-12 10:31:13 -04:00 committed by Tejun Heo
parent 4895768b6a
commit b9d6cfdeaf
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/xattr.c
View File

@ -845,7 +845,7 @@ static int __simple_xattr_set(struct simple_xattrs *xattrs, const char *name,
const void *value, size_t size, int flags)
{
struct simple_xattr *xattr;
struct simple_xattr *new_xattr = NULL;
struct simple_xattr *uninitialized_var(new_xattr);
int err = 0;
/* value == NULL means remove */