redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

floppy: make local variable non-static

Browse source 
There's no reason for temparea to be static, since it's only used for
temporary sprintf output. It's not immediately obvious that the output
will always fit (in the worst case, the output including '\0' is
exactly 32 bytes), so save a future reader from worrying about that.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Rasmus Villemoes 2015-12-01 15:54:01 +01:00 committed by Jiri Kosina
parent 8e3911178e
commit bcf4299e62
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/block/floppy.c
View file

@ -3585,7 +3585,7 @@ static void __init config_types(void)
unsigned int type = UDP->cmos; unsigned int type = UDP->cmos;
struct floppy_drive_params *params; struct floppy_drive_params *params;
const char *name = NULL; const char *name = NULL;
static char temparea[32]; char temparea[32];
if (type < ARRAY_SIZE(default_drive_params)) { if (type < ARRAY_SIZE(default_drive_params)) {
params = &default_drive_params[type].params; params = &default_drive_params[type].params;
@ -3596,7 +3596,8 @@ static void __init config_types(void)
allowed_drive_mask &= ~(1 << drive); allowed_drive_mask &= ~(1 << drive);
} else { } else {
params = &default_drive_params[0].params; params = &default_drive_params[0].params;
sprintf(temparea, "unknown type %d (usb?)", type); snprintf(temparea, sizeof(temparea),
"unknown type %d (usb?)", type);
name = temparea; name = temparea;
} }
if (name) { if (name) {