rtc: stk17ta8: let the core handle invalid time
Returning a valid time when the time is invalid is a bad practice, because then userspace is not able to react on the information. Also, it doesn't make sense to return epoch because it is already the default time. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
parent
bff11e3aa9
commit
bd7f4e7598
|
@ -129,10 +129,6 @@ static int stk17ta8_rtc_read_time(struct device *dev, struct rtc_time *tm)
|
||||||
/* year is 1900 + tm->tm_year */
|
/* year is 1900 + tm->tm_year */
|
||||||
tm->tm_year = bcd2bin(year) + bcd2bin(century) * 100 - 1900;
|
tm->tm_year = bcd2bin(year) + bcd2bin(century) * 100 - 1900;
|
||||||
|
|
||||||
if (rtc_valid_tm(tm) < 0) {
|
|
||||||
dev_err(dev, "retrieved date/time is not valid.\n");
|
|
||||||
rtc_time_to_tm(0, tm);
|
|
||||||
}
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue